Multiple decorators for a view in Django: Execution order
Now, the decorators in Python work from the inside out
Well I guess that depends on your definition of inside out. In your case, you want @login_required
to execute first, and so it should be the "outermost" (top) decorator.
As you noted, your last example works, and is indeed the correct way to do this.
edit
The confusion might be how these particular decorators work.
@login_required(@original_view)
returns a new view, which first checks if you are logged in, and then calls original_view
so
@login_required( @active_required( @my_view ) )
first checks if you are logged in, then first(second) checks if you are active, then runs my_view
Decorators are applied in the order they appear in the source. Thus, your second example:
@login_required@active_requireddef foo(request): ...
is equivalent to the following:
def foo(request): ...foo = login_required(active_required(foo))
Thus, if the code of one decorator depends on something set by (or ensured by) another, you have to put the dependent decorator "inside" the depdended-on decorator.
However, as Chris Pratt notes, you should avoid having decorator dependencies; when necessary, create a single new decorator that calls both in the right order.
It only really makes sense to stack decorators if they have truly unique functionality. Based on your description, there's never going to be a scenario where you will want to use active_required
but not login_required
. Therefore, it makes more sense to have a login_and_active_required
decorator that checks both and branches accordingly. Less to type, less to document, and negates the problem.