importing AppDelegate

Is this the the correct way for accessing these variables or should I be doing something differently?

You'll find that different people have different opinions about this. The style that I prefer is to have the app delegate pass the necessary information to the first view controller, and have that view controller pass it on to whatever view controllers it creates, and so on. The main reason for this is that it prevents child view controllers from depending on things that they have no business knowing about.

If you have some detail editor, for example, you want to be able to pass that editor exactly what it needs to do its work. If you give it that information, the editor is completely flexible -- it'll edit any information that you give it. If the editor knows that it should get its data from some external object, like the app delegate, then it loses some degree of flexibility -- it can only get data from the thing that it knows about.

So, it's fine to set up your data model in the app delegate. But when it comes to providing access to the model, think: tell, don't ask. That is, have the app delegate tell the first view controller what model object to use, and have that controller tell the next one, and so on. If you have to ask, you have to know who to ask, and that's where the dependencies start heading in the wrong direction.

every time I import AppDelegate into a .m file to access these variable's data I feel like I'm doing some wrong.

Trust that instinct. Think about why it feels wrong.

I agree that sometimes it seems like the AppDelegate is the logical place to put things that you only want implemented once but may need from several places. Creating a singleton for each one is fine, if those things are complicated, but it does create a lot of additional files and confusion to the project. I also agree with the majority of answers here, that building dependencies on the AppDelegate is a really poor design.

I think the best solution is to create a Protocol! Then put an IBOutlet to a property to do what you need to have done in each of the controllers that need the function. Protocols are the standard objective-C way to uncouple classes.

So, as an example, maybe I have a database URL that I may need from a bunch of places. Probably the best way would be to set a property with it each step along the way. But in some situations that may be cumbersome because of using a stock controller and not wanting to subclass it. Here is my solution:

Create file: MainDatabasePovider.h

#import <Foundation/Foundation.h>@protocol MainDatabaseProvider <NSObject>@required@property (nonatomic, readonly) NSURL *applicationDocumentsDirectory;@property (nonatomic, weak) NSURL *mainDatabase;@end

Now "anyone" (i.e., any class) that says it implements the MainDatabaseProvder protocol is guaranteed to provide the two methods above. This could be the AppDelegate or ANY object.

Now if I want my AppDelegate to provide the information I change the AppDelegate.h file to have:

#import "MainDatabaseProvider.h"@interface AppDelegate : UIResponder <UIApplicationDelegate, MainDatabaseProvider>@property (strong, nonatomic) UIWindow *window;@end

(The only change is to add the MainDatabaseProvider protocol to the @inteface line, again this could be done to ANY class that you want to provide the function).

In my AppDelegate.m file I have to write the two methods...

@implementation AppDelegate      ...@synthesize mainDatabase = _mainDatabase;      ...- (NSURL *) applicationDocumentsDirectory {    return [[[NSFileManager defaultManager] URLsForDirectory: NSDocumentDirectory inDomains: NSUserDomainMask] lastObject];}- (void) setMainDatabase: (NSURL *) mainDatabase {    if( _mainDatabase != mainDatabase ) {        _mainDatabase = mainDatabase;    }}- (NSURL *) mainDatabase {    if( !_mainDatabase ) {        NSURL *docURL = self.applicationDocumentsDirectory;        self.mainDatabase = [docURL URLByAppendingPathComponent: @"My Great Database"];    }    return _mainDatabase;}      ...@end

Now in my controllers or other classes that have need of getting the MainDatabase I add the following:

In their .h files:

#import "MainDatabaseProvider.h"      ...@interface myGreatViewController: UIViewController@property (nonatomic, weak) IBOutlet id <MainDatabaseProvider> mainDatabaseProvider;      ...@end

This property can be set in what was formerly known as InterfaceBuilder by control-dragging or can be set in code in prepareForSegue or I like to provide a custom getter that default it to the AppDelegate in case I am lazy or forgetful and don't do either of the above. In their .m file is would look like:

@implementation myGreatViewController@synthesize mainDatabaseProvider = _mainDatabaseProvider;      ...- (id <MainDatabaseProvider>) mainDatabaseProvider {    id appDelegate = [[UIApplication sharedApplication] delegate];    if( !_mainDatabaseProvider && [appDelegate conformsToProtocol: @protocol(MainDatabaseProvider)] )        return appDelegate;    return _mainDatabaseProvider;}// To get the database URL you would just do something like...- (void) viewWillAppear: (BOOL) animated {    NSLog( @"In %s the mainDatabaseProvider says the main database is \"%@\"", __func__, self.mainDatabaseProvider.mainDatabase.path );}

Now the mainDatabaseProvider can be ANY object. I have the ability to set it in InterfaceBuilder or my StoryBoard (although I don't really think of this is a user-interface item so I typically wouldn't but it is pretty typical to do it that way), I can set it in code outside my controller before it gets loaded in prepareForSegue:sender: or tableView:didSelectRowAtIndexPath:. And if I don't set it at all it will default to the AppDelegate if I have configured it properly.

I can even put some safe guards in for when I forget to do things in my old age by changing the getter listed above to help me out with something like:

- (id <MainDatabaseProvider>) mainDatabaseProvider {    if( !_mainDatabaseProvider ) {        id appDelegate = [[UIApplication sharedApplication] delegate];        if( ![appDelegate conformsToProtocol: @protocol(MainDatabaseProvider)] ) {            NSLog( @"Hey!! The mainDatabaseProvider is not set and the AppDelegate does not conform to the MainDatabaseProvider protocol. How do you expect me to figure out where the database is!" );        } else {            return appDelegate;    }    return _mainDatabaseProvider;}

You should seriously avoid importing the AppDelegate everywhere and you should feel like you are doing something wrong each time you do it (+1 for that). You are essentially creating a Big Ball of Mud and should reconsider your design. If for example you are using CoreData for your models consider a framework such as Magical Panda Active Record to retrieve data. I work on an enterprise application and the AppDelegate.h is only include in AppDelegate.m.