NetBeans / Java / New hint: Thread.sleep called in loop

Calling sleep in a loop typically leads to poor performance. For example:

while (true) {    if (stream.available() > 0) {       // read input    }    sleep(MILLISECONDS);}

If MILLISECONDS is too large, then this code will take a long time to realize that input is available.

If MILLISECONDS is too small, then this code will waste a lot of system resources check for input that hasn't arrived yet.

Other uses of sleep in a loop are typically questionable as well. There's usually a better way.

If it's a problem, what should I do instead?

Post the code and maybe we can give you a sensible answer.

EDIT

IMO, a better way to solve the problem is to use a ThreadPoolExecutor.

Something like this:

public void listen() {    BlockingQueue queue = new SynchronousQueue();    ThreadPoolExecutor executor = new ThreadPoolExecutor(            1, Session.getMaxSessionCount(), 100, TimeUnit.SECONDS, queue);    while (true) {        try {            queue.submit(new Session(database, serverSocket.accept()));        } catch (IOException ex) {             ex.printStackTrace();        }    }}

This configures the executor to match the way your code currently works. There are a number of other ways you could do it; see the javadoc link above.

As others have said it depends on the usage. A legitimate use would be a program that is designed to do something every 10 seconds (but is not so critical that exact timing is needed). We have lots of these "utility apps" that import data and other such tasks every few minutes. This is an easy way to perform these tasks and we typically will set the sleep interval to be very low and use a counter so that the program stays responsive and can exit easily.

int count = 0;while (true) {    try {        // Wait for 1 second.        Thread.sleep(1000);    }    catch (InterruptedException ex) {}    // Check to see if the program should exit due to other conditions.    if (shouldExit())        break;    // Is 10 seconds up yet? If not, just loop back around.    count++;    if (count < 10) continue;    // 10 seconds is up. Reset the counter and do something important.    count = 0;    this.doSomething();}

I think I come across one completely legitimate use of sleep() method in loop.

We have one-way connection between server and client. So when client wants to achieve asynchronous communication with server, he sends message to the server and than periodically polls for some response from server. There needs to be some Timeout interval.

Response resp = null;for (int i = 0; i < POLL_REPEAT && resp == null; i++) {    try {       Thread.sleep(POLL_INTERVAL);    } catch (InterruptedException ie) {    }    resp = server.getResponse(workflowId);}

POLL_REPEAT * POLL_INTERVAL ~ TIMEOUT interval