How to run a shell script in OS X by double-clicking?

• First in terminal make the script executable by typing the following command:

    chmod a+x yourscriptname

• Then, in Finder, right-click your file and select "Open with" and then "Other...".

• Here you select the application you want the file to execute into, in this case it would be Terminal. To be able to select terminal you need to switch from "Recommended Applications" to "All Applications". (The Terminal.app application can be found in the Utilities folder)

• NOTE that unless you don't want to associate all files with this extension to be run in terminal you should not have "Always Open With" checked.

• After clicking OK you should be able to execute you script by simply double-clicking it.

Have you tried using the .command filename extension?

As of OSX 10.10 (Yosemite) and since at least OS X 10.8 (Mountain Lion), the behavior is as follows when you open (double-click) executable scripts from Finder:

• Executable scripts^[1]with either NO suffix or suffix .command:
• are executed by default - no setup required:
  • a new Terminal window opens in which the script runs.
  • by default, the window will remain open after the script terminates so you can inspect the output (though at that point the shell that ran the script has exited and you cannot interact with it any longer).
    However, via Terminal's Preferences... > Profiles you can opt to automatically close the window when the script exits.
• Caveat: the working folder is invariably the current user's home folder, NOT the folder in which the script is located.
  • To make a shell script change to the folder in which it is located, place
    • cd -- "$(dirname "$BASH_SOURCE")" right after the shebang line
    • or, if you must remain POSIX-compliant, cd -- "$(dirname "$0")".
    • For edge cases, such as finding a symlinked script's true source directory, see this answer.
• If the script is unexpectedly not executable:
  • Make it executable by running chmod +x <script> in Terminal; otherwise, you'll see the following symptoms:
  • .command: Finder displays a misleading error message that suggests the problem can be fixed via File > Get Info, which is not true - use the chmod +x method suggested above.
  • no suffix:
    • with a shebang line (e.g., #!/bin/bash): behavior is as if the suffix were .sh - see below.
    • with no shebang line: opens in your default text editor (which is TextEdit by default).
• Scripts with suffix .sh, whether executable or not:
• are opened for editing in TextEdit.app or, if installed, with Xcode.app.
• Scripts with suffix .scpt or .applescript (even if they're themselves marked as executable, which is not normally the case):
  • opened for editing in [Apple]Script Editor
  • Note that the JXA source-code files seem to have no distinct suffix (yet).
• Scripts with a custom suffix (a suffix not yet known to the system), whether executable or not (in fact, applies to any kind of file):
  • prompt you for the app to open them with when you first open them, and remember that choice.

^{[1] Executable means: a script with the executable permission bit(s) set and the calling user - relative to the ownership to the file - therefore potentially being allowed to execute it.
If you use chmod a+x to set all permission bits (which is typical), anyone can invoke it (assuming they're also allowed to read the file based on the read permission bit(s) and the file's ownership).}